Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for maintenance state every 5 minutes and force refresh if changed #1315

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

kaperoo
Copy link
Contributor

@kaperoo kaperoo commented Oct 9, 2023

Description

Check for maintenance status every 5 minutes. If the status has changed from true to false - force refresh the page.

Testing instructions

Updated unit tests in App.test.tsx to check for page reloads.

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

connect to #1312

@kaperoo kaperoo linked an issue Oct 9, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7cdaffa) 96.59% compared to head (933deb4) 96.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1315   +/-   ##
========================================
  Coverage    96.59%   96.59%           
========================================
  Files           47       47           
  Lines         1701     1703    +2     
  Branches       474      475    +1     
========================================
+ Hits          1643     1645    +2     
  Misses          54       54           
  Partials         4        4           
Files Coverage Δ
src/App.tsx 87.87% <100.00%> (+0.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaperoo kaperoo marked this pull request as ready for review October 9, 2023 13:46
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works well for force-refreshing a users instance of SG. This doesn't reload the admin who unsets the maintenance mode page - but that's fine and they should know to close any instances of SG they had open before any update.

@kaperoo kaperoo merged commit d195b59 into develop Oct 12, 2023
3 checks passed
@louise-davies louise-davies deleted the feature/force-refresh-after-maintenance-#1312 branch November 3, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force refresh when site is taken out of maintenance mode
2 participants